tests: bluetooth: tester: Add support for security_changed callback #39576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area: Tests
jhedberg
reviewed
Oct 20, 2021
tests/bluetooth/tester/src/gap.c
Outdated
Member
There was a problem hiding this comment.
Wouldn't a switch statement be more natural? Note that Zephyr coding style allows variable declarations also in the middle of a scope.
Contributor
Author
There was a problem hiding this comment.
alright, I can use switch-case here
This allows to track security levels and check for lost bond of peer peripherals. This was affecting GAP/SEC/AUT/BV-21-C qualification test. Signed-off-by: Szymon Janc <[email protected]>
sjanc
force-pushed
the
tester_bond_lost
branch
from
8180b1f to
3bedbc0
Compare
jhedberg
reviewed
Oct 20, 2021
Comment on lines
+123
to
+124
| tester_send(BTP_SERVICE_ID_GAP, GAP_EV_SEC_LEVEL_CHANGED, | ||
| CONTROLLER_INDEX, (uint8_t *) &sec_ev, sizeof(sec_ev)); |
Member
There was a problem hiding this comment.
Unrelated to this PR, but seems like tester_send() could benefit from an API improvement by making the second last parameter const void * to avoid explicit typecasts.
Contributor
Author
There was a problem hiding this comment.
yes, this and also use of bt_addr_t is on my todo
jhedberg
approved these changes
Oct 20, 2021
carlescufi
approved these changes
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to track security levels and check for lost bond of peer
peripherals.
This was affecting GAP/SEC/AUT/BV-21-C qualification test.
Signed-off-by: Szymon Janc [email protected]